Fix tokenizer README repository ID #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-Huang
requested review from
tianyu-l,
fegin,
wwwjn and
wconstab
as code owners
facebook-github-bot
added
the
CLA Signed
tianyu-l
approved these changes
Jul 11, 2025
There was a problem hiding this comment.
Oh this path doesn't require the meta-llama parent folder path?
https://github.com/pytorch/torchtitan/blob/main/torchtitan/models/llama3/train_configs/llama3_405b.toml#L21
Nope, for HF the model is always in form |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1333 (comment)
Downloading from both
Meta-Llama-3.1-8BandLlama-3.1-8Bwork, but the README instructions and the .toml file are different. This changes so the README matches